[REL] [PL] FilmWeb.pl 3.0 - The Best Polish Script

[antp]

Have you deleted the file "Stringutils7552.pas" from the Scripts folder?
You can get it back from http://update.antp.be/amc/scripts/

[zbig1]

In my Scripts folder are en2pl, cp1250, StringUtils7552, BatchCommon7552, ScorEpioNCommonScript;Filmweb (PL). All up to date. After running, the same error continues. Is the above - a good configuration?

[antp]

Maybe you are missing StringUtils1.pas
That one is included indirectly by StringUtils7552.pas
If you want to remove unused scripts, in general it is better to do that only with .ifs files but to keep all the .pas files in your scripts folders, as these do not appear in the scripts list anyway.

[zbig1]

Indeed, this file was missing. Everything is laughing as it should. Thanks a lot for your help

[cosanostra]

W wersji skryptu filmweb program zaczął pobierać zdjęcia z filmu ale pobiera tylko kilka; 4,5 nie raz nawet z 7 a nie pobiera wszystkich. To samo dotyczy plakatów. obojętne jaką liczbę by nie ustawił to pobiera tylko 1 plakat.
Próbowałem wpisywać 999999 ale skrypt przez to ustawienie dużo dłużej działał a i tak pobierał tylko tą samą liczbę zdjęć czy plakatów co przy innych ustawieniach. Nie ważne czy wpisze się 5 czy 25 on i tak pobierze tyle co chce ale na pewno nie wszystkie

Przykłady:

Code: Select all

https://www.filmweb.pl/film/%C5%BBycie+za+%C5%9Bmier%C4%87-2005-123550/photos

na stronie 35 zdjęć a pobiera tylko 4

Code: Select all

https://www.filmweb.pl/film/Siódmy+syn-2014-462549

na stronie 25 zdjęć a pobiera tylko 8

Code: Select all

https://www.filmweb.pl/film/Zwarcie-2021-837065

na stronie 35 zdjęć a pobiera tylko 6

z plakatami inaczej bo zawsze pobiera tylko 1 i nic więcej

---------------------------------------------------------------------------------------

In the filmweb script version, the program started downloading photos from the film but only downloaded a few; 4,5 sometimes even 7 but it doesn't download all of them. The same applies to posters. no matter what number I set, it only downloads 1 poster. I tried entering 999999 but the script worked much longer because of this setting and it still downloaded only the same number of photos or posters as with other settings. It doesn't matter if you enter 5 or 25, it will still download as many as it wants, but definitely not all of them

Examples:

Code: Select all

https://www.filmweb.pl/film/%C5%BBycie+za+%C5%9Bmier%C4%87-2005-123550/photos

on the page there are 35 photos, but it only downloads 4

Code: Select all

https://www.filmweb.pl/film/Siódmy+syn-2014-462549

on the page there are 25 photos, but it only downloads 8

Code: Select all

https://www.filmweb.pl/film/Zwarcie-2021-837065

on the page there are 35 photos, but it only downloads 6

it's different with posters because it always downloads only 1 and nothing more

********************

Edit

Teraz to dopiero zauważyłem. Program w ogóle nie pobiera zdjęć (screenów) z filmu ze strony filmweb.pl. On pobiera zdjęcia aktorów.
Jak odznaczyłem mu pobieranie zdjęć aktorów to w ogóle nic nie pobiera żadnych zdjęć
---------------------------
I just noticed it now. The program does not download any photos (screenshots) from the film from the filmweb.pl website. It downloads photos of the actors. When I unchecked downloading photos of the actors, it did not download any photos at all

Pomocy. HELP.

[wrobelp]

Skrypt przestał pobierać plakaty z filmów, ktoś coś poradzi.

The script has stopped downloading movie posters, can someone help?

[cosanostra]

Dołączam się do prośby wyżej.

[robinse]

I cant get a movie poster

[antp]

For which movie?
I tried two, one was working:
https://www.filmweb.pl/film/Du%C5%BCy-1988-5246
another not:
https://www.filmweb.pl/film/Szklana+pu% ... -1995-1272
the second one is a .webp image instead of .jpg
AMC does not support webp (which was not as popular 20 years ago as it is now...)

[cosanostra]

Kilka przykładowych filmów, do żadnego nie pobiera plakatów.
Several sample films, none of which download posters.

https://www.filmweb.pl/film/Gru+i+Minio ... 4-10021846
https://www.filmweb.pl/film/Jutro+będzi ... 010-495689
https://www.filmweb.pl/film/Potworna+ro ... 1-10009028
https://www.filmweb.pl/film/Podróż+do+K ... 2-10021000
https://www.filmweb.pl/film/Pacific+Rim-2013-618823

[antp]

Indeed, these have webp posters instead of jpeg
So for now there is nothing that can be done in the script, AMC would have to be updated to support webp, which I don't know if it is easily doable.

Another solution would by putting some kind of conversion tool on my web server, so AMC could call that tool to retrieve the webp image converted to jpeg.
The advantage is that it would not require change in AMC, and very small change in the script.
I'll try to take a look to that solution, but I don't have much time for it now, it may be for next week but it could also have to wait a little longer.

[antp]

In the end, as it was quite easy to do, I had a few minutes just now to do that, and it seems to work.
You can get version 3.2.21 via "update scripts" or from https://update.antp.be/amc/scripts/
It seems to work fine, at least for the few movies I tested
Images are converted to jpeg 92% quality, I don't know in term of size how that compares to the images that were previously provided by filmweb.
In case they are much smaller/bigger (in file size), that could be adjusted.

[Hegemon65]

update 19.09.2024

Duration and genre are not collected

[wrobelp]

Thanks a lot for the new version, but the posters download nicely, only the movie genre stopped downloading

[cosanostra]

I also Thank You Very Much antp for fixing this and also for all the work on this project. I wish you a lot of health, that you will be with us a million years and one day longer ))

[kazeciak]

In the end, as it was quite easy to do, I had a few minutes just now to do that, and it seems to work.
You can get version 3.2.21 via "update scripts" or from https://update.antp.be/amc/scripts/
It seems to work fine, at least for the few movies I tested
Images are converted to jpeg 92% quality, I don't know in term of size how that compares to the images that were previously provided by filmweb.
In case they are much smaller/bigger (in file size), that could be adjusted.

Hello. Could you fix it so that it takes the movie genre? Thanks

[antp]

OK I'll check that, but as I said not sure this week I'll have time.

[Master_Rafael]

uprzedzam, że nie mam za bardzo wiedzy w skryptach i zrobiłem dwie poprawki analizując kod:

1. pobieranie gatunku (testowane na kilku filmach gdzie był jeden lub dwa gatunki) i raczej działa:

Code: Select all

	// Gatunek
	Line := TextBetween(Page.Text, '<div class="filmPosterSection__buttons tags-container"', '</div>');
	if Length(Line) > 0 then
	begin
		case GetOption('SeparatorGatunku') of
			0: Separator := ' / ';
			1: Separator := ', ';
			2: Separator := '/';
		end;
		Value := '';
		while Pos('/ranking/film', Line) > 0 do
		begin
			Line2 := TextBetween(Line, '/ranking/film', '/a>');
			Line := RemainingText;
			Line2 := TextBetween(Line2, 'itemprop="genre">', '<');
			Value := Value + Line2 + Separator;
		end;
		Value := Copy(Value, 1, Length(Value) - Length(Separator));
		Value := StringReplace(Value, ', ', Separator);
		UniToPol(Value);
		if Length(Value) > 0 then
			SetField(fieldCategory, Trim(Value));
	end;

2. ilość głosów pobiera się teraz tak np. 3,9 tys. , przywróciłem to do stanu np. 3897

Code: Select all

	// Ratting filmweb
	Line := TextBetween(Page.Text, 'filmRating filmRating--filmRate filmRating--hasPanel', 'filmRatingHeader');
	Rates := TextBetween(Line, 'filmRating__rateValue">', '<');
	Rates := StringReplace(Rates, ',', '.');
	if Length(Rates) > 0 then
		SetField(fieldRating, Trim(Rates));
	if CanSetCustomField('VotesFilmweb') then
	begin
		Value := TextBetween(Line, ' data-count="', '">');
		if Length(Value) > 0 then
			SetCustomField('VotesFilmweb', Trim(Value));
	end;

Uprzedzam, że może to nie działać ze wszystkimi filmami dobrze bo nie testowałem tego na dużą skalę. Dodatkowo mogę stwierdzić, że raczej jestem zielony w kodowaniu

[kazeciak]

Uprzedzam, że może to nie działać ze wszystkimi filmami dobrze bo nie testowałem tego na dużą skalę. Dodatkowo mogę stwierdzić, że raczej jestem zielony w kodowaniu

Też chciałbym być taki zielony w kodowaniu Działa jak należy na nowych i starych filmach
Dzięki i pozdrawiam

[wrobelp]

Uprzedzam, że może to nie działać ze wszystkimi filmami dobrze bo nie testowałem tego na dużą skalę. Dodatkowo mogę stwierdzić, że raczej jestem zielony w kodowaniu

Możesz dalej być tak zielony, jak jesteś w kodowaniu, skrypt działa jak ulał, wielkie dzięki