Page 1 of 6

[UPD] [NL] MovieMeter.nl

Posted: 2005-05-05 20:10:45
by Maanjak
Download the latest MovieMeter.nl script here. This script is created and maintained by AntP, not by me.

Download MovieMeter (NL).ifs

Be sure to also have the latest version of the common StringUtils1 file :

Download StringUtils1.pas

Posted: 2005-05-05 20:31:54
by Caveman
That was quick.... :)
It works like a charme, keep up the good work :grinking:

Posted: 2005-05-05 21:06:50
by antp
I rewrote the script this afternoon :/ (and I put it on my site with the other updated scripts)
http://www.antp.be/temp/scripts/MovieMeter%20(NL).ifs
I do not know which one of the two scripts is the best now :D

Posted: 2005-05-06 14:48:37
by Guest
works like a charm, thank you all for the quick updates!

script

Posted: 2005-05-08 11:31:29
by mucuracat
Hoi,
script werk niet goed.. als er film is met zelfde titel andere jaar .. krijg je de eerste geimporteerd

Posted: 2005-05-08 13:17:15
by antp
Can you give an example of such movie?

I corrected a bug in my script, it seems that something changed since friday on the site.

Posted: 2005-05-08 13:27:18
by Guest
Doesn't work 100%, when I try to add The Big One (Michael Moore) it cant be found, but it is on the site

Posted: 2005-05-08 14:43:30
by Guest
A film called sahara

Posted: 2005-05-08 15:05:12
by mucuracat
film sahara komt 3 maal voor met verschillende jaren. en de eerste wordt geselecteerd :-(

Posted: 2005-05-08 15:49:06
by antp
With my script when I search "Sahara" it shows a list :??:

Posted: 2005-05-08 16:52:39
by JanC
To the people who have rewritten my script: thanks.

Like I wrote to some people who e-mailed me: I use Linux (Ubuntu) almost full-time now and I can't use AMC there, so updating the script would have been a bit difficult for me now. :p

One request: can my e-mail address be removed from the script? People still mail me about bugs in v2.0 and that's a waste of both their and my time. ;)

BTW: Antoine, thanks for writing AMC, I really liked using it. :)

Posted: 2005-05-08 16:55:33
by antp
OK, I'll remove your address ;)

Posted: 2005-05-08 17:28:13
by JanC
Thanks! :)

Posted: 2005-05-08 18:56:55
by Maanjak
JanC: Removed the adress. :)


So far, I'm aware of two bugs in my script.
  • The first was sent to me by email: When there are multiple movies with the same name, an empty list shows up. Example: "Scarlet Pimpernel".

    The second one I noticed myself. When I searched for the movie "Mindhunters", the script doesn't download the description, the rating and the picture.
Haven't gotten around to fixing these bugs yet, but I will soon!



I also noticed that the quick search function on the Moviemeter site itself (the little text box at the top) doesn't work properly all the time. It can be really hard to find a movie if the title contains part of another movie. For example: Spider-Man. If you search for 'Spider', you get only the movie 'Spider'. If you search for 'Spide', you get a list with all movies that contain that text, including the above two.
This is only the case when using the quick search feature. If you search using the full search on the website, you can find anything without trouble. This problem is at Moviemeter, so there's not much I can do about it, but I'm pretty sure they'll fix it. And if they don't, I'll try to alter the script so it uses the main search instead of the quick search.

Posted: 2005-05-08 19:43:48
by antp
Maanjak wrote: So far, I'm aware of two bugs in my script.
  • The first was sent to me by email: When there are multiple movies with the same name, an empty list shows up. Example: "Scarlet Pimpernel".

    The second one I noticed myself. When I searched for the movie "Mindhunters", the script doesn't download the description, the rating and the picture.
Haven't gotten around to fixing these bugs yet, but I will soon!
These two work fine with my script :hihi:

Is it really useful that we maintain both a script for this site?
The script that I made has less code because I used functions made for the new IMDB script. So it will also be easier to correct if the site changes.

Posted: 2005-05-08 20:02:13
by mucuracat
antp wrote:
Maanjak wrote: So far, I'm aware of two bugs in my script.
  • The first was sent to me by email: When there are multiple movies with the same name, an empty list shows up. Example: "Scarlet Pimpernel".

    The second one I noticed myself. When I searched for the movie "Mindhunters", the script doesn't download the description, the rating and the picture.
Haven't gotten around to fixing these bugs yet, but I will soon!
These two work fine with my script :hihi:

Is it really useful that we maintain both a script for this site?
The script that I made has less code because I used functions made for the new IMDB script. So it will also be easier to correct if the site changes.
Try to find SAHARA with your script.. There are 3.. with diiferent years. and you can't chouse.. you get the first one..

keep up the good work..
greetings

Posted: 2005-05-08 20:36:12
by antp
Works fine for me...

Posted: 2005-05-08 21:46:00
by Maanjak
I just updated the script, all bugs described above are now fixed. Actually they were all caused by the same problem in my code. :)

antp wrote:Is it really useful that we maintain both a script for this site?
The script that I made has less code because I used functions made for the new IMDB script. So it will also be easier to correct if the site changes.
Can't argue with that :) Having two scripts only makes it confusing for other users. I suppose your script is indeed the one to be kept, as it is indeed easier to maintain. I'll leave my script available for download in the near future, but I won't make any major updates to it anymore. If it stops working due to a website change, I'll remove it entirely.

Still, I learned quite some things which might be useful for possible upcoming scripts, so I don't consider it a waste of time. :)

Moviemeter 2.1 dependencies

Posted: 2005-05-14 00:00:38
by Marcel
I found out that the stringutils1.pas is also updated.
Perhaps that file can have a version number and the script that use those routines, can first check if the right (or minimal) version number is okay.

For people that just update 1 script but didn't know that that is such a dependency!

Still busy with one error

Posted: 2005-05-14 00:22:27
by Marcel
I found out that some pages don't have a 'height: 465px' but another like 'height: 490px' and that goes wrong for the Categorie part.

So I fixed line 56 into:
Value := TextBetween(PageText, '<div id="film_info" style="height: 4', '<br />');

and this seems to work.
Can one of the maintainers of the source see if i'm correct?
ps films to check:
master en commander (has 465)
birth (has 490)