IMDB script doesn't work

If you made a script you can offer it to the others here, or ask help to improve it. You can also report here bugs & problems with existing scripts.
antp
Site Admin
Posts: 9692
Joined: 2002-05-30 10:13:07
Location: Brussels
Contact:

Re: IMDB script doesn't work

Post by antp »

MrObama2022 wrote: 2025-06-18 00:10:35 There are a lot of a code to check, test, add, etc. but if you want to test ..
Thank you very much for your work!
Do you continue to work on it?
I guess it would be counter-productive to both work at the same time on it, as the changes would overlap.
But if I can help for something, I can try.

I suppose we could already publish that script as an updated version of the older one? It is better anyway than the one which does not work, even if it is not finished.
antp
Site Admin
Posts: 9692
Joined: 2002-05-30 10:13:07
Location: Brussels
Contact:

Re: IMDB script doesn't work

Post by antp »

Line 606-607 (in AMC),

Code: Select all

      if (fieldName = fieldLength) then
        FieldValue := IntToStr(StrToInt(GetParam('MaxActors'), 10) / 60);
I assume that the use of GetParam here is a copy/paste mistake as it makes no sense :)
The purpose is to convert the duration from seconds to minutes. In Pascal/Delphi, "/" is for floating-point numbers, so it generates an error. For an integer division you have to use "div", so:

Code: Select all

      if (fieldName = fieldLength) then
        FieldValue := IntToStr(StrToInt(fieldValue, 10) div 60);
This fixes import of length info
MrObama2022
Posts: 67
Joined: 2022-02-02 00:03:55

Re: IMDB script doesn't work

Post by MrObama2022 »

Thank you, antp, and thank you humungus for your feedback.

Yes, I'll continue to work on it to finish. I'll ask for your help to improve details because I never used a lot of iMDB options so I don't know which values are expected.

Consider the new page format maybe does not contain all the info of the previous format, so I still don't know if I can replace 100% of parameters with the new page.

Now I need an ice-cream and a coffee to wake up, I'll update asap.
Dorohedoro
Posts: 55
Joined: 2016-12-13 00:45:45

Re: IMDB script doesn't work

Post by Dorohedoro »

MrObama2022 wrote: 2025-06-18 16:42:29 Thank you, antp, and thank you humungus for your feedback.

Yes, I'll continue to work on it to finish. I'll ask for your help to improve details because I never used a lot of iMDB options so I don't know which values are expected.

Consider the new page format maybe does not contain all the info of the previous format, so I still don't know if I can replace 100% of parameters with the new page.

Now I need an ice-cream and a coffee to wake up, I'll update asap.
Thanks for you hard work and amazing first try.

Some issues I've found:

Is ignoring the following options:

ActorsLayout option 0
Awards option 0
ImageKind option 3

Is not importing the Rating of any movie and is not importing the Producers of some movies.
MrObama2022
Posts: 67
Joined: 2022-02-02 00:03:55

Re: IMDB script doesn't work

Post by MrObama2022 »

Thank you Dorohedoro.

Here a new version, 5.0 beta 2

CHANGELOG
* fixed Length (AMC error)
* fixed Producers (sometime missing)
* fixed Composers (sometime missing)
* fixed Writers (sometime missing)
* added rating (and UserRatings)
* added ActorsLayout
* added AllActors

To do:
* Awards
* check/add all the options from Awards to TranslatedTitle (and MAYBE I could ask for help because I don't know how all these options worked before)
* TESTTTTTTTTTTTTTTTTTT
Valmiki
Posts: 10
Joined: 2023-11-20 21:14:07

Re: IMDB script doesn't work

Post by Valmiki »

MrObama2022 wrote: 2025-06-18 16:42:29 Thank you, antp, and thank you humungus for your feedback.

Yes, I'll continue to work on it to finish. I'll ask for your help to improve details because I never used a lot of iMDB options so I don't know which values are expected.

Consider the new page format maybe does not contain all the info of the previous format, so I still don't know if I can replace 100% of parameters with the new page.

Now I need an ice-cream and a coffee to wake up, I'll update asap.
Thank you so much Mr Obama for your super job. If you are not living far away I will definitely invite you for a coffee. I live near Perugia.
Anyway you really made my day.

I tried to import 2 new movies and I see that now it all works again. Yuppi.

I noticed some fields previously mentioned in previous posts (I will write them again) and some I found out. I wanted to make a simple test with a previously imported movie where I had all following values imported ... and that now aren't imported anymore. Hope it helps:

Directors
Composer
Producer
Writer
IMBD Rating
MOVIE Rating

If I can do something more. Don't hesitate to ask.
Post Reply